convert javascript snippets to standalone embedded js files (part 1) #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The advantages of runtime.CallFunctionOn are: 1. it's safe to pass arguments into js; 2. the js function can be bound to a remote object (accessed by "this"). So that we can use runtime.CallFunctionOn to run js function without constructing js dynamically.
Note: there is a performance cost here. Before the changes, just one CDP command is sent: - Runtime.evaluate After the changes, three CDP command are sent: - DOM.resolveNode: to get the RemoteObjectId from NodeId - Runtime.callFunctionOn - Runtime.releaseObject
ZekeLu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose is to make it easy to maintain the js source code.
This PR contains three parts:
dom.ScrollIntoViewIfNeeded()to replace the js implementationparseRemoteObjectfunction and improve the docCallFunctionOnand refactor the poll action to use the this funcEvaluatewithCallFunctionOnto execuate js on node. Pros and cons:CallFunctionOnneeds 3 commands to execute js on a node (whileEvaluatejust needs one):DOM.resolveNodeRuntime.callFunctionOnRuntime.releaseObject.move js function into standalone js files and load them with//go:embed//go:embedis a new feature in go 1.16, so we should put this PR on hold until we decide to drop support for go 1.15 (maybe when go 1.17 is released?).Maybe it's better to split this PR into 3 PRs.Update: We will split it into 2 PRs. Item 1 and item 2 will be released first. Item 3 will be put into another PR and it's planed to be released once go 1.17 is released.