dispatch input and change events at the chromedp.SetValue target
#819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZekeLu
changed the title
input and change event after chromedp.SetValueinput and change events at the chromedp.SetValue target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chromedp.SetValueis supposed to be called againstinput,textareaandselect. For these kind of elements, dispatchinginputandchangeevents after their values are changed is required.The document says
chromedp.SetValuesupports other elements with a.valuefield. Theinputandchangeevents will be fired for those elements too. But I'm not ware of such an element, so there is not unit test to cover this case.Fixes #607