make NewRemoteAllocator
accept url without devtools/browser/...
#817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A full websocket debugger URL is something like this:
And the ID part is not static, which requires extra work to get the correct URL for
chromedp.NewRemoteAllocator
.This change allows the client to just pass the base URL to
chromedp.NewRemoteAllocator
. It will send a request to/json/version
to get the full websocket debugger URL if the provided URL is not a valid websocket debugger URL.After the change, the URL with the following formats are accepted:
ws://127.0.0.1:9222/
http://127.0.0.1:9222/
Do not use URL in the following formats because they contain
/devtools/browser/
and will be considered as valid websocket debugger URLs:ws://127.0.0.1:9222/devtools/browser/
ws://127.0.0.1:9222/devtools/browser/
http://127.0.0.1:9222/devtools/browser/120e6fb7-0094-47a2-8b4c-51741797f280
Fixes #438.