Fix some of the issues in the Poll action #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
most of the source code is duplicated with the Query action, so the source code is extracted into a function.
The scenario: 1. the js in poll.html will set globalThis.__FOO to 1 with a 10ms timeout; 2. the js function pollMutation() checks the predicate at the very first run. When step 2 happens after step 1, pollMutation() will fulfill without DOM mutation; which will fail the tests.
|
@ZekeLu appreciate the work here. A silly question, the @gmail.com address used in your commits, do you ever monitor that email? I had emailed you (personally) about a month ago, and never got a reply. |
|
@kenshaw Oh, I don't check the inbox for a long time. gmail is blocked here 😢 so I don't check it frequently. I'm going to have a check now. Sorry! update: Just read through your email. I'm so excited to hear from you! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Poll action failed the tests very often. I have found two issues in the implementation:
runtime.ExecutionContextIDto be available.WithPollingMutation()option is unreliable.This PR fixes those issues.
@kenshaw Sorry to ping you directly, but can you take some time to review this changes? The buggy implementation has already been merged into the master branch, I hope that the issues can be addressed asap. Thank you very much!