New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose os.Process from the Browser #737
Conversation
Co-authored-by: Dmytro Vovk <dmitry-vovk@users.noreply.github.com>
@mvdan please take a look |
@kenshaw maybe you look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some more comments. Please take a look.
Sorry to quibble but let's try our best to make it better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ZekeLu I'm fine with this. Absolutely no problem exposing lower internals in general. |
Thank you all! I'm going to merge this request. |
Hi,
I've see #566, but we need a pid to control memory for all Chrome processes. We use this to export prometheus metrics with the consumed memory of sessions, for displaying on the Grafana dashboard.
Usage: