[1.7] Fix extra http headers #413
Merged
+37
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricodias
force-pushed
the
fix-header-syntax-in-setExtraHTTPHeaders
branch
from
a4fc67c to
9f490d3
Compare
Ensures that `setExtraHTTPHeaders` is called after `Network.enable`. Adjust tests to actually try to send the headers to chrome.
enricodias
force-pushed
the
fix-header-syntax-in-setExtraHTTPHeaders
branch
from
9f490d3 to
0547470
Compare
GrahamCampbell
requested changes
Aug 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct syntax is
['headers' => $headers].Network.setHTTPHeadersmust be sent per page instance, afterNetwork.enable.Page::setExtraHTTPHeaderswill now throw an exception if the response contains an error. The tests were modified to actually try to send the headers to chrome, to make them fail if we get an exception.Fixes #404