Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Support for Docs page #40

Open
riotrah opened this issue Sep 23, 2022 · 0 comments
Open

[Request] Support for Docs page #40

riotrah opened this issue Sep 23, 2022 · 0 comments

Comments

@riotrah
Copy link

riotrah commented Sep 23, 2022

Hi! Wonderful work here.

I've noticed a recent merge of a PR that ostensibly adds support for docs page, but cannot tell if I's facing a bug, or I've misunderstood that PR. Looking at the code for the PR, and the code as-is in preset/manager.js:

    match: ({ viewMode }) => viewMode === "story",

It looks as though it's still conditionally rendering only in the "Canvas" tab - no?

I'd like to either see its continued presence in the "global" toolbar area no matter the current viewMode, or, see the button in each canvas block in the docs page in addition to existing behavior otherwise.

Regarding the latter suggestion: I'd tried really hard to find API or documentation about configuring or changing the toolbar for the primary story canvas in the docs page, and have had no luck. Would love to know if you guys know any better there.

In any case thanks again! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant