Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff not showing correctly in the snippets #720

Open
jonniebigodes opened this issue Jul 6, 2023 · 3 comments
Open

Diff not showing correctly in the snippets #720

jonniebigodes opened this issue Jul 6, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@jonniebigodes
Copy link
Collaborator

jonniebigodes commented Jul 6, 2023

When a user browses the tutorials, he's faced with an issue where the snippets defined as a diff (e.g., Simple Component section) mentioning the required changes are not showing up correctly. For example:

diff-not-showing-prod

However, this situation doesn't happen when running a development build of the tutorials website. For example:

diff-working-dev-mode

What needs to happen:

  • Vet and isolate the problem and provide a workable solution to allow the diff snippets to be accurately displayed.

Thanks for the reminder @valentinpalkovic and @cdedreuille; if you have any ideas for design, would love to pair on them with you and address this issue.

@jonniebigodes jonniebigodes added the bug Something isn't working label Jul 6, 2023
@cdedreuille
Copy link

@jonniebigodes I would be happy to help with this one. We need to see what the highlighter could do.

Let's pair whenever you want.

@jonniebigodes
Copy link
Collaborator Author

To try and figure out the issue, I did some preliminary testing, and something may be happening on the deployment front.

  • Added a new script to test the production build locally with the following:
     {
       "scripts": {
         "build:local": "gatsby build && gatsby serve"
     } 
  • Ran it locally and opened up the production build available at http://localhost:9000/ and checked the Intro to Storybook tutorial's simple component page, and it yielded the following:

diff-loading-local-prod-build

@fpigeonjr
Copy link

same issue on Safari 😞
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants