Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbosnap not trigger on dependency update #927

Closed
Ankoge opened this issue Feb 21, 2024 · 5 comments
Closed

Turbosnap not trigger on dependency update #927

Ankoge opened this issue Feb 21, 2024 · 5 comments
Labels
bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation

Comments

@Ankoge
Copy link

Ankoge commented Feb 21, 2024

We had a dependency update ("@chakra-ui/storybook-addon": "5.1.0") and that update cause an error in all storybook component, but no turbosnap made so the PR got an approve.

@Ankoge Ankoge added bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation labels Feb 21, 2024
@cgbl-90
Copy link

cgbl-90 commented Feb 21, 2024

@Ankoge could you reach out to our support chat so we can dig a little deeper?

@mmuth
Copy link

mmuth commented Apr 15, 2024

HI @Ankoge

I am currently struggling with similar issues (and already contacted the support)...

My observation is, that I have troubles with multiple package.json files in the same repo. I can configure base-urls/config-urls etc. whatever I want, but only changes to the package.json in the root directory of the repo trigger dependency-changes... Unfortunately all my code/storybook/chromatic is some levels deeper in the file tree.

I can update you if you have more info. @cgbl-90 if you have further ideas, I'd be glad (well, taking a look at your name I assume I am writing with you over the support :D)

@mmuth
Copy link

mmuth commented Apr 15, 2024

@Ankoge i hope i don't hijack your thread, but just adding some details on the things i discovered (possibly they fit to your troubles)...

I enabled the --debug flag and changed something in the package.json.. Then the log looks like:

Traversing dependencies for 2 files that changed since the last build
21:33:06.435  {"packageMetadataChanges":[{"changedFiles":["service/microfrontend/package.json"],"commit":"16013627f01a5ed76098fdab88f98778be28c34d"}]} Finding changed dependencies for 1 baselines
21:33:06.443  {"rootPath":"/home/my-git-root/git/my-repo","rootManifestPath":"package.json","rootLockfilePath":"yarn.lock"} Found manifest and lockfile
21:33:06.446  {"pathPairs":[["package.json","yarn.lock"]]} Found 1 manifest/lockfile pairs to check
21:33:06.446  {"filteredPathPairs":[]} Found 0 manifest/lockfile pairs to diff

(Context: the one package.json taken seems to be that in the repo root. While the one I really changed and the one I really use is service/microfrontend/package.json, which is my project package.json)

As you can see, it decides that no dependencies were changed (which is, in fact, wrong) and then skips all snapshots.

@JonathanKolnik
Copy link
Contributor

Appreciate it @mmuth! Hopefully @cgbl-90 and the team will get you sorted out.

@Ankoge if you could also submit the results of the publish with --debug set that would be super helpful in debugging this. We can probably assist you better via support chat.

@winkerVSbecks
Copy link
Member

Closing since this was moved to support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation
Projects
None yet
Development

No branches or pull requests

5 participants