Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont check for Chromatic-package-update in CI-environment #914

Closed
work933k opened this issue Feb 7, 2024 · 1 comment
Closed

Dont check for Chromatic-package-update in CI-environment #914

work933k opened this issue Feb 7, 2024 · 1 comment
Labels
bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation

Comments

@work933k
Copy link
Contributor

work933k commented Feb 7, 2024

Bug report

I don't think it makes sense to check for an updated version of Chromatic in a CI-environment. Please check for the presence of the environment variable "CI" as many other tools do.

Also not all local NPM-repositories support the current implementation and there is no option to skip-update-check (at this time):

Using custom npm registry: https://pkgs.dev.azure.com/dummy/_packaging/DummyApps/npm/registry/
{
  body: `{"$id":"1","innerException":null,"message":"TF400813: The user 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa' is not authorized to access this resource.","typeName":"Microsoft.TeamFoundation.Framework.Server.UnauthorizedRequestException, Microsoft.TeamFoundation.Framework.Server","typeKey":"UnauthorizedRequestException","errorCode":0,"eventId":3000}`
} HTTPClient failed to fetch https://pkgs.dev.azure.com/dummy/_packaging/DummyApps/npm/registry/chromatic, got 401/Unauthorized
Could not retrieve package info from registry; skipping update check
Error: HTTPClient failed to fetch https://pkgs.dev.azure.com/dummy/_packaging/DummyApps/npm/registry/chromatic, got 401/Unauthorized

As we are using NX and we run Chromatic on all affected libraries. The CI-pipeline gets this message about xx times in the logs.

@work933k work933k added bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation labels Feb 7, 2024
@work933k
Copy link
Contributor Author

Implemented option "--skipUpdateCheck" in: #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working needs triage Tracking: Issue needs confirmation
Projects
None yet
Development

No branches or pull requests

2 participants