Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - No network issue #251

Closed
ghengeveld opened this issue Mar 22, 2024 · 0 comments · Fixed by #303
Closed

UI - No network issue #251

ghengeveld opened this issue Mar 22, 2024 · 0 comments · Fixed by #303
Assignees
Labels
bug Classification: Something isn't working sev:S2

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Mar 22, 2024

From AP-4366

How is the user affected? And what is the expected behavior?

When a user enables the addon, and for any reason the connection is lost at various stages of the process (e.g., auth, verify changes), he's left with a broken state with the following:

  • Endless spinner for auth
  • A blank page with the message "Loading" when trying to verify changes

Here's some recordings of the issue:

no-network-connection-message.mp4
auth-no-internet-connection.mp4
no-network-usage-loading-message.mp4

Based on a quick search of the Figma spec file, the design was implemented but never made it to current iteration for some reason. This is a simple fix that will improve the user experience and avoid confusion. This scenario is not rare and can happen and we should handle it gracefully.

Additionally, as we're in the stabilization phase, it would be in our best interest to ensure that the error messages we provide in the UI are clear and actionable. This will help users understand what's happening and what they can do to fix the issue as reported in #issue and also

How many and/or what class of users does this impact?

All

What are the steps for reproducing the issue?

For auth:

1. Setup a new Storybook project (or use an existing one)

2. Remove the Chromatic configuration file

3. Start Storybook

4. Disable the network connection

For changes verification:

Repeat the same steps as above but after enabling the addon and following the project link steps, disable the network connection.

@ghengeveld ghengeveld added the bug Classification: Something isn't working label Mar 22, 2024
@shilman shilman added this to the post-launch stabilization milestone Mar 28, 2024
@ghengeveld ghengeveld self-assigned this May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working sev:S2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants