Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading animation for snapshot image #256

Open
ghengeveld opened this issue Mar 22, 2024 · 2 comments · May be fixed by #309
Open

Loading animation for snapshot image #256

ghengeveld opened this issue Mar 22, 2024 · 2 comments · May be fixed by #309
Assignees
Labels
enhancement Classification: Improvement to existing feature

Comments

@ghengeveld
Copy link
Member

From AP-3661

Sometimes when I click on a story, the snapshot image takes a few moments to load. In the meantime, the panel where it goes is just empty. I would like to see a loader appear there immediately to maintain Storybook's snappy local feel.

@ghengeveld ghengeveld added the feature Classification: New feature label Mar 22, 2024
@MichaelArestad
Copy link
Contributor

This was overlooked in the initial implementation, but it should look like this:
image

Figma source

@MichaelArestad
Copy link
Contributor

I bumped up priority here because sometimes they take a while to load with no indication that anything is loading.

@shilman shilman added enhancement Classification: Improvement to existing feature and removed feature Classification: New feature labels Mar 28, 2024
@shilman shilman added this to the post-launch stabilization milestone Mar 28, 2024
@ghengeveld ghengeveld self-assigned this May 16, 2024
@ghengeveld ghengeveld linked a pull request May 16, 2024 that will close this issue
@ghengeveld ghengeveld changed the title Loader for snapshot image Loading spinner for snapshot image May 21, 2024
@ghengeveld ghengeveld changed the title Loading spinner for snapshot image Loading animation for snapshot image May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Classification: Improvement to existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants