Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Misleading information for non authenticated or expired auth tokens #250

Open
ghengeveld opened this issue Mar 22, 2024 · 1 comment
Labels
bug Classification: Something isn't working sev:S4

Comments

@ghengeveld
Copy link
Member

ghengeveld commented Mar 22, 2024

From AP-4360

How is the user affected? And what is the expected behavior?

When a user enables the Visual tests addon as part of their Storybook setup and tries to open a new browser in which he's not authenticated or the auth token has expired, the user is presented with the following UI:

Non-UI-expired-token

This feels like a regression, and the messaging needs to be clarified as the user has a project setup, including the configuration file. To which the user should be instructed to authenticate and not switch to a different account as the message suggests.

Additionally, the "Configuration should be improved" message bar, should be removed, more even as the user already has the project set up and the configuration file in place which can lead to confusion from the user as he's not sure what to do next or what the message is referring to.

How many and/or what class of users does this impact?

All

What are the steps for reproducing the issue?

  • Setup a Storybook with the Visual tests addon enabled
  • Run a build
  • Open a new browser in which you're not authenticated or the auth token has expired to see the information.
@ghengeveld ghengeveld added bug Classification: Something isn't working sev:S4 labels Mar 22, 2024
@MichaelArestad
Copy link
Contributor

  1. I think we should have two links. One, a button, should say "Reauthenticate", and the second a link, "Switch account". We don't want to indicate if a project exists or not in CH.

  2. That "Configuration should be improved" message is showing up often at the wrong time/place. We should have a discussion to work out when to show it in another issues.

@ghengeveld ghengeveld added this to the post-launch stabilization milestone May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Classification: Something isn't working sev:S4
Projects
None yet
Development

No branches or pull requests

2 participants