New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve security: sanitize html, validate links and add namespace to html ids #49

Closed

christianvoigt opened this issue May 14, 2018 · 1 comment

Owner

christianvoigt commented May 14, 2018

Markdown-It provides a good model how to improve security:

sanitize html: https://github.com/markdown-it/markdown-it/blob/master/lib/common/utils.js
validate links: https://github.com/markdown-it/markdown-it/blob/master/lib/index.js
prevent dom clobbering by adding namespaces to html ids and names: Header anchors [needs discussion] markdown-it/markdown-it#28

So far, the HTML export only sanitizes html. What about the svg export via viz.js and dagre-d3?

Owner Author

christianvoigt commented May 16, 2018

fixed in 0.8.2

links are now validated. In 0.8.3 it is possible to customize link validation (by changing htmlExportPlugin.defaults.validateLink).

dom clobbering was actually already avoided because type-prefixes were already added to the ids (e.g. "statement-").

christianvoigt closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment