Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(isBIC): add isBIC validation #1071

Merged
merged 3 commits into from Aug 17, 2019
Merged

Conversation

ezkemboi
Copy link
Member

ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 11, 2019
- fix linter issues
- fix tests
- seperate unnecessary files changes
- closes validatorjs#1034 validatorjs#951
- Other references validatorjs#1071
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 11, 2019
- fix linter issues
- fix tests
- seperate unnecessary files changes
- closes validatorjs#1034 validatorjs#951
- Other references validatorjs#1071
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 11, 2019
- fix linter issues
- fix tests
- seperate unnecessary files changes
- closes validatorjs#1034 validatorjs#951
- Other references validatorjs#1071
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 11, 2019
- fix linter issues
- fix tests
- seperate unnecessary files changes
- closes validatorjs#1034 validatorjs#951
- Other references validatorjs#1071
- validate valid BIC
- refers part of validatorjs#951
@ezkemboi
Copy link
Member Author

I have simplified regex for this PR @profnandaa as advised in last PR.
Also, here are the reference documents for this PR
https://transferwise.com/gb/swift-codes/
https://www.commbank.com.au/support.imt.what-is-a-bank-identification-code.html
https://www.kantor.pl/list-of-bic-codes-for-polish-banks

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for PR! 🎉

@profnandaa profnandaa merged commit 23fcd9c into validatorjs:master Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants