Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zh-TW National ID Rule #1040

Merged
merged 7 commits into from Jun 18, 2019
Merged

Add zh-TW National ID Rule #1040

merged 7 commits into from Jun 18, 2019

Conversation

fantasywind
Copy link
Contributor

add Taiwan National ID Number validation rule

profnandaa
profnandaa requested changes Jun 13, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🎉 Please add tests and we should be good to go.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Jun 13, 2019
@profnandaa profnandaa added 🕑 to-be-reviewed and removed 🧹 needs-update For PRs that need to be updated before landing labels Jun 17, 2019
@profnandaa profnandaa self-assigned this Jun 17, 2019
profnandaa
profnandaa approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the PR! 🎉

@profnandaa profnandaa merged commit d7dbdd5 into validatorjs:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees

@profnandaa profnandaa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fantasywind @profnandaa