Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contribution section of readme #1143

Merged

Conversation

ezkemboi
Copy link
Member

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just fix the minor...

README.md Outdated Show resolved Hide resolved
@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Oct 13, 2019
@ezkemboi ezkemboi force-pushed the update-contribution-guideline branch from 039de8e to 32e90fa Compare October 13, 2019 12:25
@ezkemboi
Copy link
Member Author

All changes fixed @profnandaa.

@ezkemboi ezkemboi force-pushed the update-contribution-guideline branch from 32e90fa to a9906ce Compare October 13, 2019 12:58
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 🎉

@profnandaa profnandaa merged commit 71c46e1 into validatorjs:master Oct 13, 2019
@GoMino
Copy link
Contributor

GoMino commented Mar 11, 2020

Why do we keep the build artefacts in the repo ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants