From 3bdca5867acde95a2b4cbb666aec0208b3ec5bc0 Mon Sep 17 00:00:00 2001 From: Chris Bobbe Date: Thu, 20 Aug 2020 23:13:18 -0700 Subject: [PATCH] deps: Add `typescript` as dev dependency. We don't need TypeScript ourselves [1], but we want to upgrade `eslint-plugin-jest` soon, and a rather distant dependency has a peer dependency of TypeScript (as we also saw in 01593b3af). Here's the output: ``` warning "eslint-plugin-jest > @typescript-eslint/experimental-utils > @typescript-eslint/typescript-estree > tsutils@3.17.1" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta". ``` Ah well, at least we can put it in `devDependencies`. And `yarn why typescript` reveals that `prettier-eslint` and `prettier-eslint-cli` have both already been bringing it in as their dependency. Those libraries are using version 3.9.7, so we set the range to include that version, so we can avoid pulling in a new copy. [1] #3458 is open to consider migrating from Flow to TypeScript, but that's not what this commit is about. --- package.json | 1 + yarn.lock | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index b5f90b141b0..500799c6ef8 100644 --- a/package.json +++ b/package.json @@ -137,6 +137,7 @@ "react-native-cli": "^2.0.1", "redux-mock-store": "^1.5.1", "rollup": "^2.26.5", + "typescript": "^3.9.7", "yarn-deduplicate": "^1.1.1" } } diff --git a/yarn.lock b/yarn.lock index 6ca01205517..a53e0ae60aa 100644 --- a/yarn.lock +++ b/yarn.lock @@ -9803,7 +9803,7 @@ typescript-compiler@^1.4.1-2: resolved "https://registry.yarnpkg.com/typescript-compiler/-/typescript-compiler-1.4.1-2.tgz#ba4f7db22d91534a1929d90009dce161eb72fd3f" integrity sha1-uk99si2RU0oZKdkACdzhYety/T8= -typescript@^3.2.1, typescript@^3.4, typescript@^3.9.3: +typescript@^3.2.1, typescript@^3.4, typescript@^3.9.3, typescript@^3.9.7: version "3.9.7" resolved "https://registry.yarnpkg.com/typescript/-/typescript-3.9.7.tgz#98d600a5ebdc38f40cb277522f12dc800e9e25fa" integrity sha512-BLbiRkiBzAwsjut4x/dsibSTB6yWpwT5qWmC2OfuCg3GgVQCSgMs4vEctYPhsaGtd0AeuuHMkjZ2h2WG8MSzRw==