Image Loading Core library #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbutcher
reviewed
Sep 25, 2020
...loading-core/src/main/java/dev/chrisbanes/accompanist/imageloading/AndroidDrawablePainter.kt
Show resolved
Hide resolved
nickbutcher
reviewed
Sep 25, 2020
...loading-core/src/main/java/dev/chrisbanes/accompanist/imageloading/AndroidDrawablePainter.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Sep 25, 2020
...loading-core/src/main/java/dev/chrisbanes/accompanist/imageloading/AndroidDrawablePainter.kt
Show resolved
Hide resolved
nickbutcher
reviewed
Sep 25, 2020
...loading-core/src/main/java/dev/chrisbanes/accompanist/imageloading/AndroidDrawablePainter.kt
Show resolved
Hide resolved
nickbutcher
reviewed
Sep 25, 2020
...loading-core/src/main/java/dev/chrisbanes/accompanist/imageloading/AndroidDrawablePainter.kt
Show resolved
Hide resolved
nickbutcher
reviewed
Sep 25, 2020
imageloading-core/src/main/java/dev/chrisbanes/accompanist/imageloading/ImageLoad.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Sep 25, 2020
imageloading-core/src/main/java/dev/chrisbanes/accompanist/imageloading/ImageLoad.kt
Show resolved
Hide resolved
nickbutcher
reviewed
Sep 25, 2020
imageloading-core/src/main/java/dev/chrisbanes/accompanist/imageloading/ImageLoadState.kt
Outdated
Show resolved
Hide resolved
nickbutcher
reviewed
Sep 25, 2020
imageloading-core/src/main/java/dev/chrisbanes/accompanist/imageloading/ImageLoadState.kt
Outdated
Show resolved
Hide resolved
…geloading/ImageLoadState.kt Co-authored-by: Nick Butcher <nickbutcher@users.noreply.github.com>
…geloading/ImageLoadState.kt Co-authored-by: Nick Butcher <nickbutcher@users.noreply.github.com>
Might be the cause of the emulator crashes on CI
chrisbanes
force-pushed
the
cb/imageloading
branch
from
c6b1ae2
to
c649c77
Compare
nickbutcher
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits out a lot of the common logic in the
coilmodule into a separateimageloadingmodule. The code left incoilis concentrated solely on the integration with the Coil library.As part of this we also have some new features:
Painters as the drawing primitive to pass around.Painters, we have a newAndroidDrawablePainterwhich can draw a AndroidDrawable.Drawables, we now support things like GIFs.As part of the refactoring, we also made some package changes, moving a lot of the common code to the
imageloadingpackage.This PR means we can easily add support for other image loading libraries very easily (PR incoming for Picasso).