Fix using CoilImage with an implicit size #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently CoilImage only works when you specific a size Modifier, since it waits for onPositioned to be called, and only starts a Coil request when it has a non-zero size. If no Modifier is provided, the CoilImage will have a zero size and we never execute a Coil request. Fixed by moving back to WithConstraints to move the request size logic to be based on the incming constraints, rather than the final size, which is probably more correct anyway.
handstandsam
suggested changes
Aug 14, 2020
There was a problem hiding this comment.
Nice, thanks for addressing this!
Can you create a new constant called UNSPECIFIED which can be Int.MAX_VALUE behind the scenes? It makes for more readable code IMO. I would suggest null, but I see that all these things are not nullable so an UNSPECIFIED reads fine in this case.
Sounds good, done. |
handstandsam
approved these changes
Aug 14, 2020
manuelvicnt
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
CoilImageonly works when you specific a size Modifier, since it waits foronPositionedto be called, and only starts a Coil request when it has a non-zero size. If no Modifier is provided, theCoilImagewill have a zero size and we never execute a Coil request.Fixed by moving back to
WithConstraintsto move the request size logic to be based on the incoming constraints, rather than the final size, which is probably more correct anyway.