Update to Compose SNAPSHOT #6658922 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Required some changes to generateMaterialThemeFromMdcTheme().
Calling composable functions is no longer allowed within
remember {} calls, so I converted generateMaterialThemeFromMdcTheme()
to be non-composable. There was no real need for it to be composable,
other than convenient access to ambients.
chrisbanes
force-pushed
the
cb/snapshot-6658828
branch
from
77ac3ee
to
2c1d774
Compare
chrisbanes
changed the title
nickbutcher
approved these changes
Jul 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required some changes to
generateMaterialThemeFromMdcTheme(). Calling composable functions is no longer allowed withinremember {}calls, so I convertedgenerateMaterialThemeFromMdcTheme()to be non-composable. There was no real need for it to be composable, other than convenient access to ambients.