Fix CoilImage not refreshing if data changes #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelvicnt
approved these changes
Jul 7, 2020
chrisbanes
force-pushed
the
cb/data-changes
branch
from
81e5f0a
to
156802e
Compare
We were using a `state` for storing any previous results, which meant that we would use the same result, regardless of whether the data/request changes. Fixed by using `stateFor(data)` instead. While writing the test, I also found that loading drawables with no intrinsic size (`<shape>`s, etc) would crash while being drawn to a bitmap. Fixed by passing through the request size as a fallback.
chrisbanes
force-pushed
the
cb/data-changes
branch
from
3526db6
to
267bcd1
Compare
chrisbanes
force-pushed
the
cb/data-changes
branch
from
267bcd1
to
579d986
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using a
statefor storing the previous load result, which meant that we would use the same result, regardless of whether the data/request changes. Fixed by usingstateFor(data)instead.While writing the test, I also found that loading drawables with no intrinsic size (
<shape>s, etc) would crash while being drawn to a bitmap (because they have 0px intrinsic width/height). Fixed by passing through the request size as a fallback.