Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PicassoImage not maintaining aspect ratio when resizing #121

Merged
merged 2 commits into from Oct 14, 2020
Merged

Fix PicassoImage not maintaining aspect ratio when resizing #121

merged 2 commits into from Oct 14, 2020

Conversation

chrisbanes
Copy link
Contributor

We now use centerInside() which maintains aspect ratio, but could lead to images being scaled smaller than the composable.

Closes #118

@chrisbanes chrisbanes merged commit 6e5a05e into main Oct 14, 2020
@chrisbanes chrisbanes deleted the cb/picasso-aspect branch October 14, 2020 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelvicnt manuelvicnt manuelvicnt approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PicassoImage doesn't scale correctly when Modifier.aspectRatio() is used
3 participants
@chrisbanes @manuelvicnt @googlebot