Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Glide integration library #113

Merged
merged 19 commits into from Oct 15, 2020
Merged

Glide integration library #113

merged 19 commits into from Oct 15, 2020

Conversation

chrisbanes
Copy link
Contributor

@chrisbanes chrisbanes commented Oct 12, 2020 •
edited

Now working 馃コ

  • Update README
  • Fix docs setup
  • Add sample activities
  • Extract common test code to new imageloading-testutils library

Closes #112

@chrisbanes chrisbanes force-pushed the cb/glide branch 2 times, most recently from 576a148 to c53982a Compare October 15, 2020 12:08
@chrisbanes chrisbanes changed the title [WIP] Glide integration library Glide integration library Oct 15, 2020
@chrisbanes chrisbanes marked this pull request as ready for review October 15, 2020 12:08
nickbutcher
nickbutcher approved these changes Oct 15, 2020
View reviewed changes
Copy link
Collaborator

@nickbutcher nickbutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small comments but largely LGTM.

@chrisbanes chrisbanes merged commit b9880f2 into main Oct 15, 2020
@chrisbanes chrisbanes deleted the cb/glide branch October 15, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickbutcher nickbutcher nickbutcher approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for image loading using Glide
3 participants
@chrisbanes @nickbutcher @googlebot