Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into supporting JS-based running of this function #283

Open
chinthakagodawita opened this issue Feb 7, 2022 · 1 comment
Open

Look into supporting JS-based running of this function #283

chinthakagodawita opened this issue Feb 7, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@chinthakagodawita
Copy link
Owner

chinthakagodawita commented Feb 7, 2022

e.g. #282

This will conflict with #181 (and #272)

AC:

  • A dist folder with the built JS of this action
  • A CD workflow that updates the dist folder when changes are merged to master
@chinthakagodawita chinthakagodawita added the enhancement New feature or request label Feb 7, 2022
@ken-matsui
Copy link
Contributor

@chinthakagodawita
To respond to your question in #282 (review),

If you are hard to keep the dist directory up-to-date, then you just update the dist directory when autoupdate is released.

I think that you previously did the following steps:

$ git commit -am "release v2.0.0"
$ git tag v2.0.0
$ git push origin v2.0.0
$ docker build -t chinthakagodawita/autoupdate:v2.0.0 .
$ docker push chinthakagodawita/autoupdate:v2.0.0

However, I would say new steps are much simpler:

$ yarn build  # Outputs to the `dist`
$ git commit -am "release v2.0.0"
$ git tag v2.0.0
$ git push origin v2.0.0

For users, JS-based actions are faster than Docker-based actions because of no need for the docker pull process. JS-based actions can enforce matching the version and real data because we commit the dist directory. Therefore, JS-based actions can avoid the maintainers' possible mistakes such as a version mismatch between the Docker image and the GitHub Release. Additionally, if you want to invite a new maintainer, you will not need to grant access to DockerHub.

These are advantages of JS-based actions I think, but I ultimately would like to respect your opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants