Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): http-proxy 1.18.1 #442

Merged
merged 1 commit into from May 18, 2020
Merged

chore(deps): http-proxy 1.18.1 #442

merged 1 commit into from May 18, 2020

Conversation

chimurai
Copy link
Owner

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.13% when pulling 8917646 on http-proxy-1_18_1 into 7104ebe on master.

@vtereshyn
Copy link

Please, merge this PR. We're waiting for resolving audit issue in several repositories!

@chimurai chimurai merged commit 07fcd38 into master May 18, 2020
@chimurai chimurai deleted the http-proxy-1_18_1 branch May 18, 2020 16:24
@chimurai
Copy link
Owner Author

published in http-proxy-middleware@1.0.4

@lvenkatraman
Copy link

lvenkatraman commented May 19, 2020

is the fix available ? I tried upgrading to 1.0.4 and I got TypeError: proxy is not a function
wherever I used imports..
const proxy = require('http-proxy-middleware');

@lvenkatraman
Copy link

do I need to have a dependency on http-proxy for this to work?

@chimurai
Copy link
Owner Author

Good to always check the changelog for breaking changes when you upgrade to a new major version.

You'll see that the import/require changed:

https://github.com/chimurai/http-proxy-middleware/releases/tag/v1.0.0

@lvenkatraman
Copy link

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http-proxy vulnerability is a high vulnerability in npm audit
4 participants