Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): handle rejected promise in custom router #413

Merged
merged 2 commits into from Mar 14, 2020
Merged

fix(router): handle rejected promise in custom router #413

merged 2 commits into from Mar 14, 2020

Conversation

bforbis
Copy link
Contributor

@bforbis bforbis commented Mar 13, 2020

Fixes #411

@ghost
Copy link

ghost commented Mar 13, 2020 •
edited by ghost

Congratulations 🍻. DeepCode analyzed your code in 0.161 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

💬 This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.

☺️ If you want to provide feedback on our bot, here is how to contact us.

@coveralls
Copy link

coveralls commented Mar 13, 2020 •
edited

Coverage Status

Coverage increased (+0.08%) to 88.13% when pulling ab10af9 on bforbis:bugfix/handled-promise-rejection-in-router into cb64266 on chimurai:master.

@chimurai chimurai merged commit 514c08b into chimurai:master Mar 14, 2020
@chimurai
Copy link
Owner

published a new version: http-proxy-middleware@1.0.2

Thank for helping out!

@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do Not Proxy Request When Custom Router Throws Error
3 participants
@bforbis @coveralls @chimurai