Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow override of parachain pallet ID and authorize_upgrade call ID #12

Merged
merged 3 commits into from Jul 7, 2022

Conversation

Kailai-Wang
Copy link
Contributor

resolves #11

This PR adds two extra envs to allow override of parachain pallet ID and authorize_upgrade call ID

Copy link
Owner

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project does not use the readme.md directly. The source is actually README_src.adoc and the md is generated. You do not need to bother about the generation itself though but could you please move your doc to the .adoc file ?

The syntax is almost identlical to what you have besides the url which should be http://example.com[some text] instead of [some text](http://example.com)

@Kailai-Wang
Copy link
Contributor Author

Thanks @chevdor
I reverted README.md and moved the document to examples/05_build_opts.yml

@chevdor
Copy link
Owner

chevdor commented Jul 7, 2022

We cannot do that: the examples/05_build_opts.yml should be a valid yaml file.

Ideally, what we should do is create a new example, include it to the adoc and add your comments in the adoc file.
I would then merge it and regenerate the readme.

@chevdor
Copy link
Owner

chevdor commented Jul 7, 2022

To add an example, you may edit this file:
https://raw.githubusercontent.com/chevdor/srtool-actions/master/examples/index.adoc

to include the new example, and you can add comments in the adoc file.

@Kailai-Wang
Copy link
Contributor Author

sorry I didn't know that.

I tried to restructure the docs a bit according to your suggestions, please also feel free to edit directly if needed :)

I was not sure if I should include the parachain-overrides.adoc in the index.adoc or README_src.adoc, but I chose the latter eventually..

@chevdor
Copy link
Owner

chevdor commented Jul 7, 2022

Thank you very much for your efforts @Kailai-Wang. I can take it from here.
Note that the doc currently is erroneous as it suggests v0.4.0 contains your overrides.
I will fix that.

@chevdor chevdor merged commit 4b3319b into chevdor:master Jul 7, 2022
@Kailai-Wang
Copy link
Contributor Author

Thanks. I'm sure I'll do it better next time 🚀

@Kailai-Wang Kailai-Wang deleted the override-parachain-pallet branch July 7, 2022 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibility to override parachain pallet ID
2 participants