Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BeamEmissionMultiplet with more accurate MSE calculation #410

Open
Balazs-Peter opened this issue Feb 27, 2023 · 1 comment · May be fixed by #415
Open

Update BeamEmissionMultiplet with more accurate MSE calculation #410

Balazs-Peter opened this issue Feb 27, 2023 · 1 comment · May be fixed by #415

Comments

@Balazs-Peter
Copy link

The spectrum calculation in the current BeamEmissionMultiplet class uses constant line intensity ratios, but in a real situation the ratios also depend on the observation direction. Better intensity ratios, or a method to calculate them might also be available.

@vsnever
Copy link
Member

vsnever commented Apr 12, 2023

Hi @Balazs-Peter, sorry for not replying for so long.

There is a PR #400, which moves the line shape models to a dedicated submodule (see #396). I think it's better to wait for #400 to be merged before creating a PR for BeamEmissionMultiplet.

In terms of implementation, BeamEmissionMultiplet should not have atomic data hard-coded. At the moment, atomic data distributed within Cherab goes to cherab/core/atomic/data, and models access it through the AtomicData interface. Also, I would like BeamEmissionMultiplet to be compatible with Marchuk's data as the most advanced atomic data for MSE at the moment, even if we can't distribute it within Cherab. The latter means that all component ratios (σ10, π23, etc.) must be functions of the beam energy and electron density.

@vsnever vsnever linked a pull request May 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants