Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all unused imports in v2 files #484

Closed
kevingreenman opened this issue Oct 5, 2023 · 5 comments
Closed

Remove all unused imports in v2 files #484

kevingreenman opened this issue Oct 5, 2023 · 5 comments
Assignees
Labels
todo add an item to the to-do list
Milestone

Comments

@kevingreenman
Copy link
Member

No description provided.

@kevingreenman kevingreenman added this to the v2.0.0 milestone Oct 5, 2023
@JacksonBurns
Copy link
Member

We should also isort the imports. And the removal can be done automatically by something like autoflake8

@kevingreenman kevingreenman added the todo add an item to the to-do list label Oct 6, 2023
@davidegraff
Copy link
Contributor

thoughts on using ruff -> black as a pre-commit hooks?

@kevingreenman kevingreenman self-assigned this Jan 11, 2024
@kevingreenman kevingreenman modified the milestones: v2.0.0, v2.1.0 Mar 1, 2024
@KnathanM
Copy link
Contributor

KnathanM commented Apr 2, 2024

#714 now enforces no unused imports. @JacksonBurns what is our status with sorted imports? Is that enforced with flake8?

@JacksonBurns
Copy link
Member

By default flake8 does not enforce a sort order on imports, although we could add it with the flake8-import-order plugin (see the docs, or isort as mentioned above.

@JacksonBurns
Copy link
Member

Actually it occurs to me that this issue can be closed since the original topic has been resolved. Let's chat offline about if we want to enforce sorting/how and then open a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
todo add an item to the to-do list
Projects
None yet
Development

No branches or pull requests

4 participants