Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any way for pooling (multiple progress bars) with v3? #166

Closed
pgollangi opened this issue Aug 27, 2020 · 12 comments · Fixed by #188
Closed

Is there any way for pooling (multiple progress bars) with v3? #166

pgollangi opened this issue Aug 27, 2020 · 12 comments · Fixed by #188

Comments

@pgollangi
Copy link
Contributor

pgollangi commented Aug 27, 2020

Pooling can be done with v1 pb.NewPool(). Is there any way to achieve this with v3?

@cheggaaa
Copy link
Owner

unfortunately not yet, but it is planned

@medyagh
Copy link

medyagh commented Apr 27, 2021

first of all thank you for this beautiful lib, we use it in minikube happily ! I would be interested to have this feature too

@medyagh
Copy link

medyagh commented Jul 20, 2021

@cheggaaa is this still a planned work ?

@cbehopkins
Copy link

Pool for v3 would be really useful for me.

I was about to hack up a prototype of it on my own fork, but if this is going to be done soon I'd love to help.

@cheggaaa
Copy link
Owner

That is because I can't find a good technical solution. But maybe just copy pooling from v1 will be better than nothing.

@cheggaaa cheggaaa linked a pull request Jul 22, 2021 that will close this issue
@cheggaaa
Copy link
Owner

Just made PR, but I need help with testing on Windows

@cbehopkins
Copy link

cbehopkins commented Jul 22, 2021

Just fired that branch up

$ go test .
# github.com/cheggaaa/pb/v3 [github.com/cheggaaa/pb/v3.test]
.\pool_win.go:15:18: undefined: getCursorPos
.\pool_win.go:25:9: undefined: setCursorPos

I can look at fixing this, and do a pr or I can keep running tests from the branch?

@cheggaaa
Copy link
Owner

I can look at fixing this, and do a pr or I can keep running tests from the branch?

Pushed fix, can you look now?

@cbehopkins
Copy link

cbehopkins commented Jul 22, 2021

I can look at fixing this, and do a pr or I can keep running tests from the branch?

Pushed fix, can you look now?

$ go test -race .
ok      github.com/cheggaaa/pb/v3       2.245s

Edit: Thanks very much for being so quick on this, I'll look at start using this asap - looks great. I'll shout if I find any further problems

@cheggaaa
Copy link
Owner

Thank you @cbehopkins !
This implementation has some disadvantages it's about cases while terminal resizing or when bars do not fit by height.
And if you (or someone) have ideas on how we can improve that - PR is welcome!

@yayaha
Copy link

yayaha commented Aug 11, 2021

Hi @cheggaaa, do you plan to merge #188 soon? Having a pool implementation with some disadvantages is definitely better than having nothing for us. Is there anything we can do to help?

@cheggaaa
Copy link
Owner

Yes, planning to add some improvements and merge that on the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants