Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the v2 branch for Solaris/Illumos. #116

Merged
merged 1 commit into from Nov 29, 2017
Merged

Conversation

sean-
Copy link
Contributor

@sean- sean- commented Nov 29, 2017

Without this fix the v2 branch doesn't test or compile against Illumos/Solaris.

$ go test -v                                                                                                  
=== RUN   TestElementPercent                                                                                                                                  
--- PASS: TestElementPercent (0.00s)                                                                                                                          
=== RUN   TestElementCounters                                                                                                                                 
--- PASS: TestElementCounters (0.00s)  
=== RUN   TestElementBar               
--- PASS: TestElementBar (0.23s)       
=== RUN   TestElementSpeed             
--- PASS: TestElementSpeed (0.00s)     
=== RUN   TestElementRemainingTime     
--- PASS: TestElementRemainingTime (0.00s)                                     
=== RUN   TestElementElapsedTime       
--- PASS: TestElementElapsedTime (0.00s)                                       
=== RUN   TestElementString            
--- PASS: TestElementString (0.00s)    
=== RUN   TestElementCycle             
--- PASS: TestElementCycle (0.00s)     
=== RUN   TestAdaptiveWrap             
--- PASS: TestAdaptiveWrap (0.00s)     
=== RUN   TestRegisterElement          
--- PASS: TestRegisterElement (0.00s)  
=== RUN   TestPBBasic                  
--- PASS: TestPBBasic (0.00s)          
=== RUN   TestPBWidth                  
--- PASS: TestPBWidth (0.00s)          
=== RUN   TestPBTemplate               
--- PASS: TestPBTemplate (0.00s)       
=== RUN   TestPBStartFinish            
--- PASS: TestPBStartFinish (0.20s)    
=== RUN   TestPBFlags                  
--- PASS: TestPBFlags (0.00s)          
=== RUN   TestPBProxyReader            
--- PASS: TestPBProxyReader (0.00s)    
=== RUN   TestProgressBarTemplate      
--- PASS: TestProgressBarTemplate (0.00s)                                      
=== RUN   TestTemplateFuncs            
--- PASS: TestTemplateFuncs (0.00s)    
=== RUN   TestUtilCellCount            
--- PASS: TestUtilCellCount (0.00s)    
=== RUN   TestUtilStripString          
--- PASS: TestUtilStripString (0.00s)  
=== RUN   TestUtilRound                
--- PASS: TestUtilRound (0.00s)        
=== RUN   TestUtilFormatBytes          
--- PASS: TestUtilFormatBytes (0.00s)  
PASS                                   
ok      github.com/cheggaaa/pb  0.465s 

Without the patch:

$ go test -v
# gopkg.in/cheggaaa/pb.v2/termutil
../../../gopkg.in/cheggaaa/pb.v2/termutil/term_x.go:48:47: undefined: ioctlReadTermios
../../../gopkg.in/cheggaaa/pb.v2/termutil/term_x.go:57:47: undefined: ioctlWriteTermios
../../../gopkg.in/cheggaaa/pb.v2/termutil/term_x.go:66:47: undefined: ioctlWriteTermios
FAIL    github.com/cheggaaa/pb [build failed]

@coveralls
Copy link

coveralls commented Nov 29, 2017

Coverage Status

Coverage remained the same at 97.099% when pulling 9af190b on sean-:fix-illumos-v2 into 72576f8 on cheggaaa:v2.

@cheggaaa cheggaaa merged commit 1e4033b into cheggaaa:v2 Nov 29, 2017
@cheggaaa
Copy link
Owner

Thank you!

@sean- sean- deleted the fix-illumos-v2 branch November 29, 2017 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants