Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Supermarket 'Version Tag Metric' metric #2183

Open
tas50 opened this issue Aug 24, 2021 · 3 comments
Open

Remove the Supermarket 'Version Tag Metric' metric #2183

tas50 opened this issue Aug 24, 2021 · 3 comments
Assignees
Labels
Component: Quality Metrics Involving fieri, the cookbook quality metrics feature

Comments

@tas50
Copy link
Contributor

tas50 commented Aug 24, 2021

This is something we should check in Cookstyle instead. Once #2181 is complete we should remove this metric.

@tas50 tas50 added the Status: Untriaged An issue that has yet to be triaged. label Aug 24, 2021
@tas50 tas50 added this to the Stuff we could do milestone Sep 24, 2021
@tas50 tas50 added Component: Quality Metrics Involving fieri, the cookbook quality metrics feature and removed Status: Untriaged An issue that has yet to be triaged. labels Sep 27, 2021
tas50 added a commit to chef/cookstyle that referenced this issue Sep 29, 2021
This allows us to implement chef/supermarket#2183

Signed-off-by: Tim Smith <tsmith@chef.io>
@saghoshprogress
Copy link
Contributor

We need to remove this metric.

Screenshot 2022-01-03 at 6.49.48 PM.png

@saghoshprogress
Copy link
Contributor

We need to verify the same Metric in cookstyle PR before we remove this Metric.

@sanga1794 , @msys-sgarg Please check and confirm

@msys-sgarg
Copy link
Contributor

msys-sgarg commented Jan 27, 2022

@skkprogress @tas50

  • Version Tag metric is not only taking care of version tag in metadata.rb but also is checking whether attribute source_url is present in metadata or not , also it should be containing valid github url value.. We display failure - Failure: To pass this metric, your cookbook metadata must include a source url, the source url must be in the form of https://github.com/user/repo, and your repo must include a tag that matches this cookbook version number like this in case of invalid source_url.

  • Also, cookstyle will not cover the case where version tag is missing altogether .. only if version tag is present and contains an invalid version cookstyle will throw an error

Please let me know if still version tag metric is ok to be removed ?

@msys-sgarg msys-sgarg self-assigned this Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Quality Metrics Involving fieri, the cookbook quality metrics feature
Projects
None yet
Development

No branches or pull requests

3 participants