Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist SystemConfiguration libs #1021

Merged
merged 2 commits into from Jul 14, 2021
Merged

Whitelist SystemConfiguration libs #1021

merged 2 commits into from Jul 14, 2021

Conversation

jayashrig158
Copy link
Contributor

Description

This will fix issue on mac_os :

The precise failures were:
--> /opt/chef-workstation//embedded/lib/libcurl.4.dylib
DEPENDS ON: SystemConfiguration
COUNT: 1
PROVIDED BY: /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration
FAILED BECAUSE: Unsafe dependency

Maintainers

Please ensure that you check for:

  • [] If this change impacts git cache validity, it bumps the git cache
    serial number
  • [] If this change impacts compatibility with omnibus-software, the
    corresponding change is reviewed and there is a release plan
  • [] If this change impacts compatibility with the omnibus cookbook, the
    corresponding change is reviewed and there is a release plan

@jayashrig158 jayashrig158 self-assigned this Jun 16, 2021
@jayashrig158 jayashrig158 requested review from a team as code owners June 16, 2021 12:34
@tduffield
Copy link
Contributor

tduffield commented Jun 16, 2021

@jayashrig158 I know at one point our goal was to address the Aruba issues so that the verify tests at least ran. Where are we on that effort?

@tas50
Copy link
Contributor

tas50 commented Jun 16, 2021

In the future this sort of change needs to get merged before the omnibus-software change. The pipeline for anything using curl on macos is currently broken which is blocking a Workstation release.

@tduffield
Copy link
Contributor

That's my bad.

@jayashrig158
Copy link
Contributor Author

@tduffield Regarding Aruba issues : @skeshari12 was looking into that , I'll co-ordinate with her and we'll update you on that part

Signed-off-by: jayashri garud <jgarud@msystechnologies.com>
Signed-off-by: jayashri garud <jgarud@msystechnologies.com>
@tas50 tas50 merged commit f3e6acf into master Jul 14, 2021
@tas50 tas50 deleted the jgarud/whitelist_libs branch July 14, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants