Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenSSL usage deprecation warnings from Rubocop #1994

Open
tas50 opened this issue May 15, 2020 · 0 comments
Open

OpenSSL usage deprecation warnings from Rubocop #1994

tas50 opened this issue May 15, 2020 · 0 comments
Labels
Component: oc-id Status: Sustaining Backlog An issue ideal for the Sustaining Engineering team (or anyone else if they want to adopt it). Status: To be prioritized Indicates that product needs to prioritize this issue. Triage: Confirmed Indicates and issue has been confirmed as described.

Comments

@tas50
Copy link
Contributor

tas50 commented May 15, 2020

Rubocop has a new cop that detects an upcoming deprecation to the OpenSSL gem that's built into Ruby.

The openssl introducing the deprecation:
ruby/openssl#366

The new rubocop rule currently only in master:
rubocop/rubocop#7950

/Users/tsmith/dev/work/chef-server/src/oc-id/app/models/signature.rb:17:5: W: Lint/DeprecatedOpenSSLConstant: Use OpenSSL::Digest.hexdigest('SHA1', canonical_string) instead of OpenSSL::Digest::SHA1.hexdigest(canonical_string).
    OpenSSL::Digest::SHA1.hexdigest(canonical_string)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/tsmith/dev/work/chef-server/src/oc_erchef/apps/oc_chef_wm/test/password_gen.rb:13:9: W: Lint/DeprecatedOpenSSLConstant: Use OpenSSL::Digest.hexdigest('SHA1', "--#{salt}--#{password}--") instead of OpenSSL::Digest::SHA1.hexdigest("--#{salt}--#{password}--").
        OpenSSL::Digest::SHA1.hexdigest("--#{salt}--#{password}--")
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
/Users/tsmith/dev/work/chef-server/src/oc_erchef/apps/oc_chef_wm/test/password_gen.rb:15:9: W: Lint/DeprecatedOpenSSLConstant: Use OpenSSL::Digest.hexdigest('SHA1', "#{salt}--#{password}--") instead of OpenSSL::Digest::SHA1.hexdigest("#{salt}--#{password}--").
        OpenSSL::Digest::SHA1.hexdigest("#{salt}--#{password}--")
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Aha! Link: https://chef.aha.io/features/SH-3048

@tas50 tas50 added the Status: Untriaged An issue that has yet to be triaged. label May 15, 2020
@PrajaktaPurohit PrajaktaPurohit added Component: oc-id Triage: Confirmed Indicates and issue has been confirmed as described. Status: To be prioritized Indicates that product needs to prioritize this issue. and removed Status: Untriaged An issue that has yet to be triaged. labels Jul 10, 2020
@tas50 tas50 removed the Status: To be prioritized Indicates that product needs to prioritize this issue. label Mar 19, 2021
@btm btm added Epic and removed Component: oc-id Triage: Confirmed Indicates and issue has been confirmed as described. labels May 24, 2021
@PrajaktaPurohit PrajaktaPurohit added Component: oc-id Triage: Confirmed Indicates and issue has been confirmed as described. Status: Sustaining Backlog An issue ideal for the Sustaining Engineering team (or anyone else if they want to adopt it). Status: To be prioritized Indicates that product needs to prioritize this issue. and removed Epic labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: oc-id Status: Sustaining Backlog An issue ideal for the Sustaining Engineering team (or anyone else if they want to adopt it). Status: To be prioritized Indicates that product needs to prioritize this issue. Triage: Confirmed Indicates and issue has been confirmed as described.
Projects
None yet
Development

No branches or pull requests

3 participants