Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Storybook Documentation Spike #2723

Closed
4 tasks done
Shadae opened this issue Jan 27, 2020 · 4 comments
Closed
4 tasks done

Spike: Storybook Documentation Spike #2723

Shadae opened this issue Jan 27, 2020 · 4 comments
Assignees
Labels
chef-ui-library spike something that will be investigated by a detective. ui

Comments

@Shadae
Copy link
Contributor

Shadae commented Jan 27, 2020

User Story

As a UI Developer, etc, we have decided to move forward with utilizing Material UI components within Automate to iterate faster. After a few team discussions we have also decided that to document the designed shared components we will bring in https://storybook.js.org/ to hold them for referencing. In the past we have have spun libraries to do this. But we are going to do a small exploratory spike to see what this would look like and how it will change our development process.

Definition of Done

Demo Script / Repro Steps

@Shadae Shadae added chef-ui-library spike something that will be investigated by a detective. ui labels Jan 27, 2020
@vjeffrey
Copy link

would be AWESOME to demo these spike results when ready :)

@SEAjamieD
Copy link
Contributor

SEAjamieD commented Feb 4, 2020

FYI - there is currently an issue using the latest Storybook (5.3.11)
referenced here: storybookjs/storybook#9749

All is well reported as long as you use 5.3.10 for now

I'm currently running into an issue around storybook being unable to find some Modules so if anyone figures this piece out ... please hit me up!
Screen Shot 2020-02-04 at 2 02 47 PM

@SEAjamieD
Copy link
Contributor

ok...so as kind of expected here, we need to add redux and stencil/redux as dev dependencies in the package.json

"redux": "^4.0.4",
"@stencil/redux": "^0.1.1",

@tarablack01 tarablack01 self-assigned this Feb 24, 2020
@tarablack01
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chef-ui-library spike something that will be investigated by a detective. ui
Projects
None yet
Development

No branches or pull requests

4 participants