Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken :nth-child selector #2542

Closed
harimambura opened this issue May 22, 2022 · 4 comments · Fixed by fb55/nth-check#206
Closed

Broken :nth-child selector #2542

harimambura opened this issue May 22, 2022 · 4 comments · Fixed by fb55/nth-check#206

Comments

@harimambura
Copy link

In last version ([1.0.0-rc.11]) selector with :nth-child(n) throws an error "Uncaught TypeError TypeError: getNCheck is not a function", but previous version works fine.

I use the esm package if it matters
@fb55
Copy link
Member

fb55 commented May 22, 2022 •
edited

I am unable to replicate this:

import { load } from 'cheerio';

console.log(load('<p>1<p>2')('p:nth-child(2)').text()); // 2

You likely have old package versions installed and running a rm -r node_modules package-lock.json before the npm install should resolve things.

@harimambura
Copy link
Author

harimambura commented May 22, 2022 •
edited

I am unable to replicate this:

import { load } from 'cheerio';

console.log(load('<p>1<p>2')('p:nth-child(2)').text()); // 2

You likely have old package versions installed and running a rm -r node_modules package-lock.json before the npm install should resolve things.

Clear npm cache, create new folder, init npm, set "type": "module" in package.json, next "npm i cheerio"
use the next code to reproduce:
import cheerio from 'cheerio'; const $ = cheerio.load('<html><body><div></div><div></div></body></html>'); $('body > div:nth-child(1)')

I installed cheerio a half an hour ago, this was the first install on my laptop

@fb55 fb55 mentioned this issue May 22, 2022
Merged
@fb55
Copy link
Member

fb55 commented May 22, 2022

I am able to replicate now. Turns out a default import to nth-check wasn't available, as that module was still CommonJS. Fix incoming with fb55/nth-check#206

@fb55
Copy link
Member

fb55 commented May 22, 2022

Bumping nth-check to 2.1.0 resolves the issue. That version is already in range for cheerio, so no steps are required here.

@harimambura Thank you for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add ESM fb55/nth-check
2 participants
@fb55 @harimambura