Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand CircleCI's Sonar Test #443

Open
rnveach opened this issue Oct 22, 2022 · 1 comment
Open

Expand CircleCI's Sonar Test #443

rnveach opened this issue Oct 22, 2022 · 1 comment

Comments

@rnveach
Copy link
Member

rnveach commented Oct 22, 2022

Identified by @nrmancuso when discussing the CircleCI execution,

CircleCI is generating an empty checkstyle config when it does its test run:

# cat target/sonar/checkstyle.xml 
<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE module PUBLIC "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" "https://checkstyle.org/dtds/configuration_1_3.dtd"><!-- Generated by Sonar --><module name="Checker"><module name="SuppressWarningsFilter" /><module name="TreeWalker"><module name="SuppressWarningsHolder"/> <module name="SuppressionCommentFilter" /></module></module>

This makes sense since we are dealing with an blank sonar server in the run.

We should look into injecting some checks and expand to some real tests to ensure the plugin is working correctly.

@rnveach
Copy link
Member Author

rnveach commented Oct 23, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant