Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle SQALE? #219

Open
muhlba91 opened this issue May 13, 2019 · 2 comments
Open

How to handle SQALE? #219

muhlba91 opened this issue May 13, 2019 · 2 comments
Labels

Comments

@muhlba91
Copy link
Collaborator

muhlba91 commented May 13, 2019

SonarQube seems to have deprecated SQALE:

For now, we are using the sqale.xml file to define, although only partly, the SQALE ratings of each check. However, first, they are not defined well (and for some it might be difficult defining them) and, secondly, what would be the new SQ process for those ratings?

Furthermore, for reading this XML file we rely on the deprecated (and to be removed without replacement) class https://github.com/SonarSource/sslr-squid-bridge/blob/master/src/main/java/org/sonar/squidbridge/rules/SqaleXmlLoader.java#L42.
If SQALE is still supported and need, we must ensure to have a proper implementation working on our side to be independent of this library.

Hence, check if SQALE is still mandatory - if:

  • not: remove sqale.xml and all related code
  • mandatory: copy over implementation from library, define rule and maintain them

See:

@muhlba91
Copy link
Collaborator Author

note: sqale.xml contains only an example after transitioning to loading via metadata.
to be investigated: do we need to set sqale still nowadays?

@romani
Copy link
Member

romani commented Feb 17, 2022

do we need to set sqale still nowadays?

I never understand it. Let's drop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants