Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to checkstyle 8.18 #196

Closed
romani opened this issue Feb 25, 2019 · 6 comments
Closed

upgrade to checkstyle 8.18 #196

romani opened this issue Feb 25, 2019 · 6 comments
Assignees
Labels
Milestone

Comments

@romani
Copy link
Member

romani commented Feb 25, 2019

https://checkstyle.org/releasenotes.html#Release_8.18 ,
upgrade version at https://github.com/checkstyle/sonar-checkstyle/edit/master/pom.xml#L88

from release notes:

Disable loading external DTDs by default, create system property to activate it.

not affected, but it better to update all url to "https"

IllegalType: rename "format" property to "illegalAbstractClassNameFormat".

affected. upgrade instruction: remove old instances of Check and create new.

AnnotationLocation: Remove unused tokens.

affected. upgrade instruction: remove old instances of Check and create new.

Command Line arguments should be allow to exclude a file.

not affected.

New: new filter SuppressionXpathSingleFilter.

affected. we need to provide instruction on how to use it.

ArrayTypeStyle: add support for brackets in method definition after parameters.

no affected.

@romani
Copy link
Member Author

romani commented Feb 25, 2019

@muhlba91 , please let me know if you can help us to migrate plugin to new version of checkstyle and release your fix for latest sonar support.

muhlba91 pushed a commit to muhlba91/sonar-checkstyle that referenced this issue Feb 26, 2019
@muhlba91 muhlba91 self-assigned this Feb 26, 2019
muhlba91 pushed a commit to muhlba91/sonar-checkstyle that referenced this issue Feb 26, 2019
muhlba91 pushed a commit to muhlba91/sonar-checkstyle that referenced this issue Mar 4, 2019
muhlba91 pushed a commit to muhlba91/sonar-checkstyle that referenced this issue Mar 5, 2019
muhlba91 pushed a commit to muhlba91/sonar-checkstyle that referenced this issue Mar 5, 2019
romani pushed a commit that referenced this issue Mar 6, 2019
@romani
Copy link
Member Author

romani commented Mar 7, 2019

Done and tested by @muhlba91.

@romani romani closed this as completed Mar 7, 2019
@romani romani added this to the 4.18 milestone Mar 7, 2019
@romani
Copy link
Member Author

romani commented Mar 8, 2019

RFF - https://community.sonarsource.com/t/rff-checkstyle-plugin-4-18/7576

@muhlba91 , in 2 weeks we can do RELEASE post in sonarqube (so jar will appear in marketplace).

Release process is documented at:
https://github.com/checkstyle/sonar-checkstyle/wiki/How-to-make-release please review it an let me know if smth need to be explained.

@muhlba91
Copy link
Collaborator

muhlba91 commented Mar 8, 2019

@romani

I have seen that 6. Announcements has not been done since version 4.10 - if the announcements are not done (anymore), we should remove this point in the document.

Point 8.2: where does an announcement have to be posted and how is the format of it? Or does this refer to 8.3 because then I'd fix the numbering?

@romani
Copy link
Member Author

romani commented Mar 9, 2019

if the announcements are not done (anymore), we should remove this point in the document.

I tired to do this, it is better to do this, but I do not have time.

Point 8.2: where does an announcement have to

I updated wiki page.

tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
tsjensen pushed a commit to checkstyle-addons/sonar-checkstyle that referenced this issue Mar 21, 2019
@romani
Copy link
Member Author

romani commented Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants