Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Generate Patch Tests #360

Open
rnveach opened this issue Nov 14, 2022 · 3 comments
Open

Missing Generate Patch Tests #360

rnveach opened this issue Nov 14, 2022 · 3 comments

Comments

@rnveach
Copy link
Member

rnveach commented Nov 14, 2022

Identified at https://github.com/checkstyle/patch-filters/blob/master/src/test/java/com/github/checkstyle/generatepatchfile/GeneratePatchFileTest.java#L26 ,

The test class has no tests inside. Everything inside com.github.checkstyle.generatepatchfile is uncovered.

Tests should be added for this package to cover functionality.

@romani
Copy link
Member

romani commented Nov 14, 2022

It is because we abandoned generation and rely on smart outside tools to make it.

@rnveach
Copy link
Member Author

rnveach commented Nov 14, 2022

Then should we remove code completely?

@romani
Copy link
Member

romani commented Nov 14, 2022

Let's keep it for now, as we never finished testing on real project for long period to be sure our idea was correct. As we already see patches on different OS looks a bit different.

But we can remove test file for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants