Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

duplicate nested checkstyle jar #385

Open
Bananeweizen opened this issue Nov 10, 2022 · 1 comment · Fixed by #685
Open

duplicate nested checkstyle jar #385

Bananeweizen opened this issue Nov 10, 2022 · 1 comment · Fixed by #685
Assignees
@Bananeweizen

Comments

@Bananeweizen
Copy link
Collaborator

The jar containing the main checkstyle code exists two times in eclipse-cs. Once in eclipsecs.core/lib, second time in eclipsecs.checkstyle/. To my understanding the eclipsecs.checkstyle project is meant to be the container for that lib, therefore we should remove it from eclipsecs.core/lib. Or is there any good reason to have it 2 times, that I'm not aware of?
@Bananeweizen Bananeweizen mentioned this issue Nov 16, 2022
Merged
Bananeweizen added a commit to Bananeweizen/eclipse-cs that referenced this issue Apr 1, 2024
@Bananeweizen
remove duplicate checkstyle.jar
435b2bd 
* remove and gitignore the checkstyle.jar in eclipsecs.core
* have only the copy in eclipsecs.checkstyle remain
* export packages of transitive dependencies from the
eclipsecs.checkstyle project. this is not a good practice, but
represents exactly what happened before: consuming the third party
dependencies from the checkstyle library

fixes checkstyle#385

In a follow-up change the re-exported packages should be removed, and
instead be replaced by taking the respective libraries into the target
platform.
@Bananeweizen Bananeweizen mentioned this issue Apr 1, 2024
Merged
@Bananeweizen Bananeweizen self-assigned this Apr 1, 2024
Bananeweizen added a commit to Bananeweizen/eclipse-cs that referenced this issue Apr 2, 2024
@Bananeweizen
remove duplicate checkstyle.jar
73222fe 
* remove and gitignore the checkstyle.jar in eclipsecs.core
* have only the copy in eclipsecs.checkstyle remain
* export packages of transitive dependencies from the
eclipsecs.checkstyle project. this is not a good practice, but
represents exactly what happened before: consuming the third party
dependencies from the checkstyle library

fixes checkstyle#385

In a follow-up change the re-exported packages should be removed, and
instead be replaced by taking the respective libraries into the target
platform.
Bananeweizen added a commit that referenced this issue Apr 2, 2024
@Bananeweizen
remove duplicate checkstyle.jar
d74a25f 
* remove and gitignore the checkstyle.jar in eclipsecs.core
* have only the copy in eclipsecs.checkstyle remain
* export packages of transitive dependencies from the
eclipsecs.checkstyle project. this is not a good practice, but
represents exactly what happened before: consuming the third party
dependencies from the checkstyle library

fixes #385

In a follow-up change the re-exported packages should be removed, and
instead be replaced by taking the respective libraries into the target
platform.
@Bananeweizen
Copy link
Collaborator Author

Reopening due to commit reverted.

@Bananeweizen Bananeweizen reopened this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bananeweizen Bananeweizen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate checkstyle.jar Bananeweizen/eclipse-cs
1 participant
@Bananeweizen