Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #332: Include EnumTrailingCommaAndSemicolonCheck #333

Closed
wants to merge 1 commit into from
Closed

Issue #332: Include EnumTrailingCommaAndSemicolonCheck #333

wants to merge 1 commit into from

Conversation

kariem
Copy link

@kariem kariem commented Aug 2, 2018

@rnveach
Copy link
Member

rnveach commented Aug 2, 2018

IDEA failure can be ignored. @romani Please review.

@rnveach rnveach requested a review from romani August 2, 2018 14:29
romani
romani approved these changes Aug 2, 2018
View reviewed changes
Copy link
Member

@romani romani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, should be merged as new check is merged

@kariem kariem force-pushed the 332-include-check-EnumTrailingComma branch from 88e27c0 to e87c259 Compare September 13, 2018 21:20
@kariem
Copy link
Author

kariem commented Sep 13, 2018

Renamed check based on this comment sevntu-checkstyle/sevntu.checkstyle#709 (comment)

Last change reflects that change

@kariem kariem mentioned this pull request Sep 13, 2018
Closed
@romani
Copy link
Member

romani commented Dec 30, 2018

Check is not merged yet - sevntu-checkstyle/sevntu.checkstyle#722

@romani
Copy link
Member

romani commented Jun 13, 2019

closing this PR as work on Check is not completed.

@romani romani closed this Jun 13, 2019
@Rahulkhinchi03 Rahulkhinchi03 mentioned this pull request Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romani romani romani approved these changes

@rnveach rnveach rnveach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include EnumTrailingCommaAndSemicolonCheck
3 participants
@kariem @rnveach @romani