New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update versions of some projects #250
Comments
Actually using both is better. I think we should consider adding CS backport as one of the old projects to test on. |
In property file , first value of line is name , we could define any name there and use the same repo few times |
@romani Could you please define which projects should use master and which shouldn't or are we updating them all? |
all we need is just switch to "master", if it works - lets keep it. |
@romani We made discussion that we would possibly keep both old and new. |
I do not remember this discussion, I forgot a reason to keep old(versioned config line). |
It was just a short discussion in this thread: |
ok , in this case we need to use some very ancient version of them. |
Comment from #590: Noticed at checkstyle/checkstyle#11100, many commit id's that use release versions (such as PMD, orekit, and others) need to be updated to use the newest release versions. This will require testing of each project. The easiest way to do this is to:
|
I do not remember a reason why we use exact versions in projects-to-test-on.properties
elasticsearch|git|https://github.com/elastic/elasticsearch|v1.5.2||
Example: https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/projects-to-test-on.properties#L22
right now it causing a problem that java files that are referenced in diff reports is not that simple to find in web (requires bunch of click in github to find it), as they are gone and exists only in old version of project.
But for most of project it is better to switch to most recent version or even "master".
More and more projects switch to java8 with usage of its syntax, so using latest is better. We should use old version only to small amount of project if they used weird formatting before and it was good test area for us.
The text was updated successfully, but these errors were encountered: