Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update versions of some projects #250

Open
romani opened this issue Jun 28, 2017 · 9 comments · Fixed by #597
Open

update versions of some projects #250

romani opened this issue Jun 28, 2017 · 9 comments · Fixed by #597

Comments

@romani
Copy link
Member

romani commented Jun 28, 2017

I do not remember a reason why we use exact versions in projects-to-test-on.properties
elasticsearch|git|https://github.com/elastic/elasticsearch|v1.5.2||
Example: https://github.com/checkstyle/contribution/blob/master/checkstyle-tester/projects-to-test-on.properties#L22

right now it causing a problem that java files that are referenced in diff reports is not that simple to find in web (requires bunch of click in github to find it), as they are gone and exists only in old version of project.

But for most of project it is better to switch to most recent version or even "master".
More and more projects switch to java8 with usage of its syntax, so using latest is better. We should use old version only to small amount of project if they used weird formatting before and it was good test area for us.

@rnveach
Copy link
Member

rnveach commented Jun 28, 2017

so using latest is better

Actually using both is better.
Newer projects make sure we stay up to date on latest stuff.
Older projects make sure we aren't breaking from coding behavior of old styles. I myself still prefer to code in Java 6 style.

I think we should consider adding CS backport as one of the old projects to test on.

@romani
Copy link
Member Author

romani commented Jun 28, 2017

In property file , first value of line is name , we could define any name there and use the same repo few times

@rnveach
Copy link
Member

rnveach commented Jul 30, 2017

@romani Could you please define which projects should use master and which shouldn't or are we updating them all?

@romani
Copy link
Member Author

romani commented Jul 31, 2017

all we need is just switch to "master", if it works - lets keep it.

@rnveach
Copy link
Member

rnveach commented Jul 31, 2017

@romani We made discussion that we would possibly keep both old and new.
Are we just dropping all the old?

@romani
Copy link
Member Author

romani commented Aug 1, 2017

I do not remember this discussion, I forgot a reason to keep old(versioned config line).

@rnveach
Copy link
Member

rnveach commented Aug 1, 2017

It was just a short discussion in this thread:
#250 (comment)
#250 (comment)

@romani
Copy link
Member Author

romani commented Aug 1, 2017

ok , in this case we need to use some very ancient version of them.
what CI do you think should process old versions ? If no of current , it might be better to make separate file for them, to keep projects-to-test-on short in size.

@nrmancuso
Copy link
Member

Comment from #590:

Noticed at checkstyle/checkstyle#11100, many commit id's that use release versions (such as PMD, orekit, and others) need to be updated to use the newest release versions. This will require testing of each project. The easiest way to do this is to:

  1. update each project to latest release commit, send PR to contribution
  2. open a dummy PR in checkstyle main repo where most of these projects files are used, and replace cloned contribution repo to PR branch.
  3. Make sure that all CI pass
  4. In the case of projects-to-test-on.properties, we can use this projects file with github report generation action to show successful update

nrmancuso added a commit to nrmancuso/contribution that referenced this issue Jan 28, 2022
romani pushed a commit that referenced this issue Jan 29, 2022
@romani romani reopened this Jan 29, 2022
nrmancuso added a commit to nrmancuso/contribution that referenced this issue May 31, 2022
nrmancuso added a commit to nrmancuso/contribution that referenced this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants