Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Top Button on website #8533

Closed
jo2 opened this issue Jul 17, 2020 · 12 comments · Fixed by #8541
Closed

To Top Button on website #8533

jo2 opened this issue Jul 17, 2020 · 12 comments · Fixed by #8541

Comments

@jo2
Copy link
Contributor

jo2 commented Jul 17, 2020

As mentioned in #8244 a button which scrolls to the top of the page would be nice.

@jo2
Copy link
Contributor Author

jo2 commented Jul 17, 2020

I've uploaded a preview of how this could look.

@strkkk
Copy link
Member

strkkk commented Jul 17, 2020

@jo2 I would suggest to move to left side and make it visible after used scrolled below left menu. There is an unused white space.

@romani
Copy link
Member

romani commented Jul 18, 2020

I still think it is good on right. Especially useful in mobile mode. On laptop I can always press cntl+home to go most top.

@rnveach , @pbludov , ply shared you thoughts in this.

@jo2
Copy link
Contributor Author

jo2 commented Jul 18, 2020

I've added an alternative for a button on the left and on the right side:

@romani
Copy link
Member

romani commented Jul 18, 2020

Awesome ! now I am confident that on right is much better.
If you open it in mobile - you will feel it as it covers beginning of text, so it is very unpleasant, and you always want to scroll to remove it from text.
but on right there is more chance that it cover nothing and as you know start of sentence or word you can skip reading of end.

@rnveach
Copy link
Member

rnveach commented Jul 18, 2020

We have the same type of button in my application I made at work. It is on the right so that is what I vote for.

IMO, even with the black border, the white background blends too much with the white of the page's background when it land in that spot. We made ours a different color so it stood out as a button and not part of the page.

We also made the button disappear when you were on the top of the page. It only appeared when you scroll down like 1 page down worth.

Maybe just nitpicking, but would "To Top" be better than "to Top" (capitalize t in to)?

@strkkk
Copy link
Member

strkkk commented Jul 18, 2020

In mobile it looks better on right side, I agree.

@romani
Copy link
Member

romani commented Jul 18, 2020

Maybe just nitpicking, but would "To Top" be better than "to Top" (capitalize t in to)?

I have no strong opinion, up to jo2.

About style of button, no big preference. If there be few examples , I can tell what looks better.
But for now I am happy just to have it.

@romani
Copy link
Member

romani commented Jul 18, 2020

from Travis:
scroll-top-down

@jo2
Copy link
Contributor Author

jo2 commented Jul 20, 2020

i chose white because it is one of the used colors in the page. We could use the grey from the section headings for the background and the red from the section headings for the text. To make it fit better with the other elements on the page I'd suggest to remove the rounded corners.

@romani
Copy link
Member

romani commented Jul 20, 2020

@jo2, please send PR. We can tune style even after release. Such button is good step forward

jo2 added a commit to jo2/checkstyle that referenced this issue Jul 20, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 20, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 21, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 21, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 21, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 21, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 21, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 21, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 21, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 22, 2020
jo2 added a commit to jo2/checkstyle that referenced this issue Jul 23, 2020
romani pushed a commit that referenced this issue Jul 25, 2020
@romani romani added this to the 8.35 milestone Jul 25, 2020
@romani
Copy link
Member

romani commented Jul 25, 2020

fix is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants