Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Pitest Issues - RedundantImportCheck #7920

Closed
rnveach opened this issue Mar 20, 2020 · 7 comments
Closed

Resolve Pitest Issues - RedundantImportCheck #7920

rnveach opened this issue Mar 20, 2020 · 7 comments

Comments

@rnveach
Copy link
Member

rnveach commented Mar 20, 2020

Child issue of #7797 ,

"RedundantImportCheck.java.html:<td class='covered'><pre><span class='survived'> else if (pkgName != null &#38;&#38; isFromPackage(imp.getText(), pkgName)) {</span></pre></td></tr>"

@Gaurav-Punjabi
Copy link
Contributor

I'm on it.

@Gaurav-Punjabi
Copy link
Contributor

Gaurav-Punjabi commented Mar 22, 2020

@rnveach
Copy link
Member Author

rnveach commented Mar 22, 2020

Pitest report :
https://gaurav-punjabi.github.io/checkstyle/issue-7920/pit-reports/202003221458/com.puppycrawl.tools.checkstyle.checks.imports/RedundantImportCheck.java.html#grouporg.pitest.mutationtest.report.html.SourceFile@f8857d3_120
removed conditional - replaced equality check with true → SURVIVED

Issue is not shown in pitest report. Pitest shows 100% coverage on class where our CI tells us differently. I cannot even find the line in your report that pitest is reporting, which makes me think you ran pitest on a modified branch.

Did you run pitest report on a clean checkstyle master branch?

@Gaurav-Punjabi
Copy link
Contributor

Gaurav-Punjabi commented Mar 22, 2020

Yes, I recently updated this report. Let me check.

@Gaurav-Punjabi
Copy link
Contributor

Pitest report :
https://gaurav-punjabi.github.io/checkstyle/issue-7920/pit-reports/202003221458/com.puppycrawl.tools.checkstyle.checks.imports/RedundantImportCheck.java.html#grouporg.pitest.mutationtest.report.html.SourceFile@f8857d3_120
removed conditional - replaced equality check with true → SURVIVED

Issue is not shown in pitest report. Pitest shows 100% coverage on class where our CI tells us differently. I cannot even find the line in your report that pitest is reporting, which makes me think you ran pitest on a modified branch.

Did you run pitest report on a clean checkstyle master branch?

@romani Updated the report. Please check again.

@rnveach
Copy link
Member Author

rnveach commented Mar 23, 2020

Pitest report and regression look good.

Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Mar 25, 2020
Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Mar 25, 2020
Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Mar 25, 2020
Gaurav-Punjabi added a commit to Gaurav-Punjabi/checkstyle that referenced this issue Mar 25, 2020
@strkkk strkkk added this to the 8.31 milestone Mar 26, 2020
@strkkk
Copy link
Member

strkkk commented Mar 26, 2020

Fix is merged

@strkkk strkkk closed this as completed Mar 26, 2020
Abhishek-kumar09 pushed a commit to Abhishek-kumar09/checkstyle that referenced this issue Apr 5, 2020
RayRCaringal pushed a commit to RayRCaringal/checkstyle that referenced this issue Apr 7, 2020
RayRCaringal pushed a commit to RayRCaringal/checkstyle that referenced this issue Apr 7, 2020
ImmortalRabbit pushed a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants