Resolve Pitest Issues - ImportOrderCheck (2)

[rnveach]

Child issue of #7797 ,

checkstyle/.ci/pitest.sh

Line 87 in abf829f

"ImportOrderCheck.java.html:<td class='covered'><pre><span class='survived'> final boolean separatorBetween = isStatic != lastImportStatic</span></pre></td></tr>"

[DXTkastb]

I'm on it.

[DXTkastb]

Pitest report:
https://dxtkastb.github.io/checkstyle/reports/ImportOrder/repo/com.puppycrawl.tools.checkstyle.checks.imports/ImportOrderCheck.java.html

Better Pitest report:
https://dxtkastb.github.io/checkstyle/reports/ImportOrder/repo-edited/com.puppycrawl.tools.checkstyle.checks.imports/ImportOrderCheck.java.html

Surviving Mutation:

checkstyle/.ci/pitest.sh

Line 87 in abf829f

"ImportOrderCheck.java.html:<td class='covered'><pre><span class='survived'> final boolean separatorBetween = isStatic != lastImportStatic</span></pre></td></tr>"

Hardcoded Branch:
https://github.com/DXTkastb/checkstyle/blob/5bb8ae24bb6dd655ad3789d69e3a363d37828043/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java#L698-L699

Pitest regression report:
https://dxtkastb.github.io/checkstyle/reports/ImportOrder/repo/diff/index.html
https://dxtkastb.github.io/checkstyle/reports/ImportOrder/newdiff/index.html

Code analysis:
The regression report did not provide much help.

checkstyle/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java

Lines 684 to 702 in b2b4a0b

	/**
	* Checks whether import groups should be separated.
	* @param isStatic whether the token is static or not.
	* @return true if imports groups should be separated.
	*/
	private boolean needSeparator(boolean isStatic) {
	final boolean typeImportSeparator = !isStatic && separated;
	final boolean staticImportSeparator;
	if (staticImportsApart) {
	staticImportSeparator = isStatic && separatedStaticGroups;
	}
	else {
	staticImportSeparator = isStatic && separated;
	}
	final boolean separatorBetween = isStatic != lastImportStatic
	&& (separated || separatedStaticGroups) && staticImportsApart;
	return typeImportSeparator || staticImportSeparator || separatorBetween;
	}

Line 698: We need to check when:

final boolean separatorBetween =
isStatic != lastImportStatic is true and
(separated || separatedStaticGroups) is true and
staticImportsApart is false

which will affect :

return typeImportSeparator || staticImportSeparator || separatorBetween;

if option property is not set to top/bottom then, staticImportsApart and separatedStaticGroups is false. If so, then separatorBetween will be false, but simultaneously typeImportSeparator/staticImportSeparator will be true somehow because(separated is true) :

 final boolean typeImportSeparator = !isStatic && separated; 

staticImportSeparator = isStatic && separated

if I set separated to false, then (separated || separatedStaticGroups) will shoot false and staticImportsApart will lose its last bit of importance.

[rnveach]

Fix was merged