Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Pitest Issues - ImportOrderCheck (1) #7872

Closed
rnveach opened this issue Mar 16, 2020 · 4 comments · Fixed by #8782
Closed

Resolve Pitest Issues - ImportOrderCheck (1) #7872

rnveach opened this issue Mar 16, 2020 · 4 comments · Fixed by #8782
Labels
approved good third issue miscellaneous
Milestone
8.36.1

Comments

@rnveach
Copy link
Member

rnveach commented Mar 16, 2020

Child issue of #7797 ,

checkstyle/.ci/pitest.sh

Line 86 in abf829f

"ImportOrderCheck.java.html:<td class='covered'><pre><span class='survived'> else if (matcher.start() == bestPos &#38;&#38; matcher.end() &#62; bestEnd) {</span></pre></td></tr>"

@checkstyle checkstyle deleted a comment from SunJiFengPlus Mar 22, 2020
@ImmortalRabbit
Copy link
Contributor

I am on it.

ImmortalRabbit added a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 8, 2020
@ImmortalRabbit
Issue checkstyle#7872: fixes Resolve Pitest Issues - ImportOrderCheck…
da77446 
… (1)
@ImmortalRabbit ImmortalRabbit mentioned this issue Apr 9, 2020
Closed
ImmortalRabbit added a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 9, 2020
@ImmortalRabbit
Issue checkstyle#7872: fixes Resolve Pitest Issues - ImportOrderCheck…
be56382 
… (1)
ImmortalRabbit added a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 17, 2020
@ImmortalRabbit
Issue checkstyle#7872: fixes Resolve Pitest Issues - ImportOrderCheck…
22cbd97 
… (1)
ImmortalRabbit added a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 17, 2020
@ImmortalRabbit
Issue checkstyle#7872: fixes Resolve Pitest Issues - ImportOrderCheck…
f9a2b95 
… (1)
ImmortalRabbit added a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 17, 2020
@ImmortalRabbit
Issue checkstyle#7872: fixes Resolve Pitest Issues - ImportOrderCheck…
79a0c1b 
… (1)
ImmortalRabbit added a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 19, 2020
@ImmortalRabbit
Issue checkstyle#7872: minor fix
c3f4476
ImmortalRabbit added a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 19, 2020
@ImmortalRabbit
Issue checkstyle#7872: fixes Resolve Pitest Issues - ImportOrderCheck…
e34aba3 
… (1)
ImmortalRabbit added a commit to ImmortalRabbit/checkstyle that referenced this issue Apr 19, 2020
@ImmortalRabbit
Issue checkstyle#7872: minor fix
556b4cd
@shashwatj07
Copy link
Contributor

I'm on it!

shashwatj07 added a commit to shashwatj07/checkstyle that referenced this issue Sep 3, 2020
@shashwatj07
Issue checkstyle#7872: fixes Resolve Pitest Issues - ImportOrderCheck…
3cf085c 
… (1)
@shashwatj07
Copy link
Contributor

  1. Pitest report - https://shashwatj07.github.io/202009030956/com.puppycrawl.tools.checkstyle.checks.imports/ImportOrderCheck.java.html#org.pitest.mutationtest.report.html.SourceFile@1ba917ed_943
  2. Surviving mutation - removed conditional - replaced equality check with true → SURVIVED
  3. Hardcoded branch - https://github.com/shashwatj07/checkstyle/blob/50faa2b2e32ca8ee79ab4ac2c8fefd46acce8b10/src/main/java/com/puppycrawl/tools/checkstyle/checks/imports/ImportOrderCheck.java#L943

shashwatj07 added a commit to shashwatj07/checkstyle that referenced this issue Sep 3, 2020
@shashwatj07
Issue checkstyle#7872: fixes Resolve Pitest Issues - ImportOrderCheck…
2d87a9f 
… (1)
@shashwatj07 shashwatj07 mentioned this issue Sep 3, 2020
Merged
shashwatj07 added a commit to shashwatj07/checkstyle that referenced this issue Sep 3, 2020
@shashwatj07
Issue checkstyle#7872: fixes Resolve Pitest Issues - ImportOrderCheck…
554f63f 
… (1)
pbludov pushed a commit that referenced this issue Sep 5, 2020
@shashwatj07 @pbludov
Issue #7872: fixes Resolve Pitest Issues - ImportOrderCheck (1)
07d177b
@pbludov
Copy link
Member

pbludov commented Sep 5, 2020

Fix is merged.

@pbludov pbludov added this to the 8.37 milestone Sep 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved good third issue miscellaneous
Projects
None yet
Milestone
8.36.1
Development

Successfully merging a pull request may close this issue.

Issue #7872: fixes Resolve Pitest Issues - ImportOrderCheck (1) shashwatj07/checkstyle
4 participants
@pbludov @rnveach @ImmortalRabbit @shashwatj07