Resolve Pitest Issues - IllegalImportCheck (3)

[rnveach]

Child issue of #7797 ,

checkstyle/.ci/pitest.sh

Line 84 in abf829f

"IllegalImportCheck.java.html:<td class='covered'><pre><span class='survived'> if (!result) {</span></pre></td></tr>"

[akki111singh]

I am on it

[rnveach]

Pitest is good. Branch is ok. I would actually hard code the if (true) { so as to not accidentally change more code than necessary that could affect regression.

Modules used in the config file:

Configs should be expanded to also include illegalClasses to be sure there is nothing else that could be impacting the mutation. Documentation states you should use all permutations possible for the check to cover as much as possible.

If code is removed, we need an explanation of why that is the best path. Prove it to me without a doubt.

[akki111singh]

@rnveach There is some misunderstanding

There were Pitest three issues for IllegalImportCheck:

• checkstyle/.ci/pitest.sh

  Line 84 in abf829f

  "IllegalImportCheck.java.html:<td class='covered'><pre><span class='survived'> if (!result) {</span></pre></td></tr>"

  Resolve Pitest Issues - IllegalImportCheck (1) #7854

• checkstyle/.ci/pitest.sh

  Line 83 in abf829f

  "IllegalImportCheck.java.html:<td class='covered'><pre><span class='survived'> if (!result &#38;&#38; illegalClasses != null) {</span></pre></td></tr>"

  Resolve Pitest Issues - IllegalImportCheck (2) #7855

• checkstyle/.ci/pitest.sh

  Line 82 in abf829f

  "IllegalImportCheck.java.html:<td class='covered'><pre><span class='survived'> if (regexp) {</span></pre></td></tr>"

  Resolve Pitest Issues - IllegalImportCheck (3) #7856

This was supposed to be for the first one but by mistake I did it for third one .I talked to the person who has claimed the pitest-issue i have worked on i.e Issue #7854 , he hasn't started working yet on that issue and he agreed to shift, So should i open pull request mentioning this issue or shift all my work there?

[rnveach]

@akki111singh move all your comments to the issue you are working on and remove them from the wrong issue. If your ready for PR then start PR on that issue you are working on but if code is removed, as I stated, we need proof that the code can be removed safely.

[strkkk]

This was fixed in 24b077c