Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Pitest Issues - CustomImportOrderCheck (2) #7803

Closed
rnveach opened this issue Mar 8, 2020 · 8 comments
Closed

Resolve Pitest Issues - CustomImportOrderCheck (2) #7803

rnveach opened this issue Mar 8, 2020 · 8 comments

Comments

@rnveach
Copy link
Member

rnveach commented Mar 8, 2020

Child issue of #7797 ,

"CustomImportOrderCheck.java.html:<td class='covered'><pre><span class='survived'> else if (customImportOrderRules.contains(SAME_PACKAGE_RULE_GROUP)) {</span></pre></td></tr>"

@Abhishek-kumar09
Copy link
Contributor

I am on it.

@wltan
Copy link
Contributor

wltan commented Mar 14, 2020

I recommend you take a look at #7805 as well, it might be related. Both issues involve the same boolean expression, it's possible that if you fix this one you might fix the other one as well.

@Abhishek-kumar09
Copy link
Contributor

I recommend you take a look at #7805 as well, it might be related. Both issues involve the same boolean expression, it's possible that if you fix this one you might fix the other one as well.

OK, I will look on it.

@Abhishek-kumar09
Copy link
Contributor

I want a help with this issue.:
What should I do to resolve this issue
It checks that if Import contains same_package_rule_group
should I write separate test cases for checking the import orders.
What may be the possible files changes that are needed.

@rnveach
Copy link
Member Author

rnveach commented Mar 15, 2020

@Abhishek-kumar09 Read primary steps in #7797 (comment) . It gives a blow by blow steps to find and test a fix with links and everything.

@rnveach
Copy link
Member Author

rnveach commented Mar 19, 2020

@Abhishek-kumar09 Unfortunately another issue has intertwined with this one and the other issue already has a PR started to resolve both issues. Because of this and no visible progress in 4 days, no one else can work on this issue. I recommend to try looking at another pitest issue to solve.

@Abhishek-kumar09
Copy link
Contributor

OK, I will work on another one.

@strkkk
Copy link
Member

strkkk commented Mar 20, 2020

Fix is merged

@strkkk strkkk closed this as completed Mar 20, 2020
@strkkk strkkk added this to the 8.31 milestone Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants